Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lighter color for sidebar captions #392

Merged
merged 1 commit into from Mar 22, 2017
Merged

Use lighter color for sidebar captions #392

merged 1 commit into from Mar 22, 2017

Conversation

Blendify
Copy link
Member

@Blendify Blendify commented Mar 14, 2017 •
edited

Before:

captionafter

After:

captionbefore

@agjohnson agjohnson added the PR: work in progress Pull request is not ready for full review label Mar 14, 2017
agjohnson
agjohnson approved these changes Mar 22, 2017
View reviewed changes
Copy link
Collaborator

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍 for better accessibility

@agjohnson agjohnson merged commit 6f45114 into master Mar 22, 2017
@agjohnson agjohnson deleted the brightcaptions branch March 22, 2017 23:32
@agjohnson agjohnson removed the PR: work in progress Pull request is not ready for full review label Mar 22, 2017
@jessetan jessetan mentioned this pull request Apr 26, 2018
Closed
@MarcelRaschke MarcelRaschke mentioned this pull request Aug 20, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Aug 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

@ericholscher ericholscher Awaiting requested review from ericholscher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Blendify @agjohnson