Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lists not indented properly on genindex.html #676

Merged
merged 4 commits into from Dec 8, 2018
Merged

Lists not indented properly on genindex.html #676

merged 4 commits into from Dec 8, 2018

Conversation

Blendify
Copy link
Member

@Blendify Blendify commented Oct 1, 2018 •
edited

I haven't tested this yet but it is a start to fixing this. No need to review yet.

Fixes #671

@Blendify
Lists not indented properly on genindex.html
100b480 
I haven't tested this yet but it is a start to fixing this. No need to review yet.

Fixes #671
@jessetan
Copy link
Contributor

I almost filed a PR with the code below, so consider that a premature LGTM :)

.genindextable li > ul
    margin-left: $base-line-height

@Blendify
Update CSS Selector
5e267ff 
This should also fix #685
@jessetan
Copy link
Contributor

I expect the .contents was added to fix #685, but the output of .. contents:: in the documentation of the theme already looks fine to me. With this PR there is an extra indent.

jessetan
jessetan approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@jessetan jessetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Blendify Blendify merged commit 2c15fde into master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessetan jessetan jessetan approved these changes

@agjohnson agjohnson Awaiting requested review from agjohnson

@ericholscher ericholscher Awaiting requested review from ericholscher

@davidfischer davidfischer Awaiting requested review from davidfischer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lists not indented properly on genindex.html
2 participants
@Blendify @jessetan