Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

version bump #44

Merged
merged 4 commits into from Feb 11, 2019
Merged

version bump #44

merged 4 commits into from Feb 11, 2019

Conversation

whyboris
Copy link
Contributor

@whyboris whyboris commented Feb 4, 2019

Update all the packages to their latest versions.

Note that yargs version 13.0.0 is out just not published to npm. I'm sure in a day or two it will be there: yargs/yargs#1288 (after which we'll want to update the yarn.lock in this PR) 馃憣

Note the minimum supported version of node has changed. Using anything lower than 8.12.0 will result in:
error codacy-coverage@3.4.0: The engine "node" is incompatible with this module. Expected version ">= 8.12.0".

@rtfpessoa -- please, either let me know which version you'd need to bump diff2html-cli to if this merges (or please change it yourself: https://github.com/rtfpessoa/diff2html-cli/blob/master/package.json#L3) 馃槄

update:

  • yargs v13 still hadn't been published to npm so I have v12 in this PR.
  • the codacity error I noted above doesn't seem to affect versions 6 and 7 so everything is fine 馃憣

@rtfpessoa
Copy link
Owner

After we finish the other PRs we can continue this. Thanks for the start.

@rtfpessoa
Copy link
Owner

Can you update this one?
Then I will do a release.

@whyboris
Copy link
Contributor Author

Thank you for the swift feedback on all my PRs! I'm thrilled we'll have a new release shortly 馃槃

Cheers!

@whyboris
Copy link
Contributor Author

Curiously the Codacy/PR Quality Review has been Pending for several hours 馃槙

@rtfpessoa rtfpessoa merged commit ed487ad into rtfpessoa:master Feb 11, 2019
@rtfpessoa
Copy link
Owner

Codacy has been having some issues with OSS projects.

@whyboris whyboris deleted the version-bump branch February 12, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants