Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offset is in the wrong column #19

Closed
mrfyda opened this issue Aug 10, 2015 · 2 comments
Closed

Offset is in the wrong column #19

mrfyda opened this issue Aug 10, 2015 · 2 comments
Labels
enhancement help wanted

Comments

@mrfyda
Copy link
Contributor

mrfyda commented Aug 10, 2015

screen shot 2015-08-10 at 08 54 37
@rtfpessoa
Copy link
Owner

If by offset you mean @@ -38,7 +45,7 @@ that is kind of a feature.
Since it is returned in the middle of the diff I never tried to change it's position.

The first two columns are for the the line numbers.
I'm not sure if the offset would got well there.
Any suggestion? Can you provide an example of an improvement?

@pbu88
Copy link
Contributor

pbu88 commented Dec 20, 2015

I don't think this issue stands anymore. I never really saw the issue here and is pretty much what Github does. Unless de OP provides more context I think this could be closed.

@mrfyda mrfyda closed this as completed Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrfyda @rtfpessoa @pbu88