Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wordwrap function #97

Closed
jung-kim opened this issue Sep 4, 2016 · 5 comments
Closed

Wordwrap function #97

jung-kim opened this issue Sep 4, 2016 · 5 comments

Comments

@jung-kim
Copy link
Contributor

jung-kim commented Sep 4, 2016

diff2html 2.0.1 is working well for us at Ungit and I was able to fix our custom css bindings relatively easy from 1.6.x. Except for one feature, word wrap.

CSS word-wrap will not work with diff2html's resulting html code as it is not using actual whitespace, it is using &nbsp. Because of once easy CSS class injection fix for this feature is no longer viable.

  1. What is the reasoning behind the replacing spaces with &nbsp?
  2. Can we have a word wrap feature support from diff2html? (I'd rather not have to run the html gen function again)
@rtfpessoa
Copy link
Owner

rtfpessoa commented Sep 5, 2016

Dam. I knew this would come to hunt me. Even with more tests. Can never get rid of problems. 😒

This is related to the code formatting. I will look into it. 😄

To avoid this I need to use word-wrap: pre; and then be able to have the html to not go crazy.

Will let you know as soon as I can get this.

@rtfpessoa
Copy link
Owner

@codingtwinky just added a fix in #98

Please take a look and if you can test it.

I will merge it probably tomorrow or something like that.
I just need to have a better look and see if nothing else is broken.
Since this changes some big CSS stuff.

@rtfpessoa
Copy link
Owner

@codingtwinky this should be fixed in diff2html@v2.0.4

@rtfpessoa
Copy link
Owner

@codingtwinky after release 2.0.4 I found some problem with the line css, now it should be fixed in diff2html@v2.0.6

@TiredFalcon
Copy link

I have been trying to get the diff (in lines mode) to work for some time but I cannot figure it out.
The <table> element inside the code wrapper overflows.
@jung-kim how did you manage to get the line wrapping to work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants