Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnspython and DNS over TLS #358

Closed
rthalley opened this issue Mar 24, 2019 · 7 comments
Closed

dnspython and DNS over TLS #358

rthalley opened this issue Mar 24, 2019 · 7 comments

Comments

@rthalley
Copy link
Owner

dnspython should support DNS-over-TLS (TCP). It would probably also be good to support DNS over HTTPS. DNS-over-DTLS (UDP) is probably not needed at this time.

@pspacek
Copy link
Collaborator

pspacek commented Mar 24, 2019

FYI here is how we added DNS-over-TLS on top of existing DNS-over-TCP: https://gitlab.labs.nic.cz/knot/respdiff/blob/master/respdiff/sendrecv.py#L198

@rthalley
Copy link
Owner Author

Cool

@filips123
Copy link
Contributor

filips123 commented Sep 24, 2019

@pspacek @rthalley Can this be added directly in DNSPython?

Support for DNS-over-TLS, DNS-over-HTTPS and DNSCrypt would be really needed and very useful.

@filips123
Copy link
Contributor

I'm now working on DNS-over-HTTPS support. I will probably create PR next week.

@nicki-krizek
Copy link
Collaborator

Am I correct in assuming DoT/DoH support should be added to both dns.query and dns.resolver?

If so, I wonder what the proper API for dns.resolver.Resolver should look like. The current query() takes tcp as argument, but when using tls or https, there will probably be additional context needed. To me it seems like the protocol along with some context should be a separate object to future-proof any upcoming API changes in 2.0 to allow for future extension (e.g. QUIC).

@filips123
Copy link
Contributor

filips123 commented Oct 1, 2019

@tomaskrizek I will create PR for DNS over HTTPS later today. Update: I created #393.

@rthalley
Copy link
Owner Author

rthalley commented Apr 3, 2020

This was done.

@rthalley rthalley closed this as completed Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants