Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible merge with Verschlimmbesserung #1

Open
aphyr opened this issue Apr 14, 2014 · 2 comments
Open

Possible merge with Verschlimmbesserung #1

aphyr opened this issue Apr 14, 2014 · 2 comments

Comments

@aphyr
Copy link

aphyr commented Apr 14, 2014

So this started out as a layer of code in Jepsen around etcd-clojure, then clj-etcd, then things got a little out of hand and somehow became a full-blown client. I felt bad about submitting it as a pull request to either project because there are so many breaking differences; but wanted to let you know that this thing is now out there, and you can cannibalize ideas from it if you're so inclined. It's missing watches, leaders, and locks, but I'm relatively happy with the core kv API and semantics.

Thoughts? Should I finish porting features from clj-etcd to Verschlimmbesserung? Would you like to consume part of Verschlimmbesserung into your codebase? No real strong feelings here; happy to keep the fork if you think both are valuable. :)

@rthomas
Copy link
Owner

rthomas commented Jun 12, 2014

Hey mate, sorry for the delay :)

Happy to merge them together, I'd rather we combine and focus on the one client than maintain multiple clients.

Thoughts on the best way to do this?

@aphyr
Copy link
Author

aphyr commented Jun 12, 2014

Howdy there Ryan! I put some additional work into the error handling and CAS semantics for Verschlimmbesserung, and am pretty happy with its behavior at this point, but I'd also like to include the watch/leader/lock support from clj-etcd. Maybe it'd be most straightforward to port those clj-etcd features into V? Most of the options handling/URI infrastructure is all ready to go. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants