Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtic-monotonics depends on embedded-hal-1.0.0-rc1 #821

Closed
explocion opened this issue Oct 25, 2023 · 2 comments
Closed

rtic-monotonics depends on embedded-hal-1.0.0-rc1 #821

explocion opened this issue Oct 25, 2023 · 2 comments

Comments

@explocion
Copy link

explocion commented Oct 25, 2023 •
edited
Loading

Hi,
I'm trying to use rtic-monotonics in my project. However, the newest release depends on embedded-hal version 1.0.0-rc1, where many traits are removed as they are trying to ship a stable release. This creates dependency conflicts with most HAL implementations, as they depend on embedded-hal version 1.0.0-alpha.11 or lower. A practical solution is to simply downgrade. If you think this is a good idea, I'm happy to do a PR. Thanks!
@explocion explocion mentioned this issue Oct 25, 2023
Closed
@explocion
Copy link
Author

Instead of downgrading, I think it is also feasible to make dependency of embedded-hal optional and put it in the default features. This should create minimal disruption to current users and code bases.

@explocion
Copy link
Author

I think @Dirbaio 's comment makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

incr: making embedded-hal optional
1 participant
@explocion