-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken on Ruby 1.9.2 -- rake build - no int with size 4 #48
Comments
I am using ruby 1.9.2p180 (2011-02-18 revision 30909) [x86_64-linux] and in that version, the mkmf library's $ irb -r mkmf
### ruby 1.9.2p180 (2011-02-18 revision 30909) [x86_64-linux]
>> check_sizeof("unsigned long")
checking size of unsigned long... long
"long"
>> check_sizeof("unsigned int")
checking size of unsigned int... int
"int"
>> check_sizeof("unsigned char")
checking size of unsigned char... 1
1 |
This is fixed in my fork at sunaku/rdiscount@730d12e. |
+1 |
Can't repro on latest Ruby 1.9.3p362. And the patch you've submitted makes a hardcoded assumption, so I can't take it. |
I have the same problem using ruby 1.9.2p320. Any chance of a fix? Upgrading from 1.9.2 -> 1.9.3 is not currently an option for me. Thanks. |
@dadamsuk Please try sunaku's patch sunaku/rdiscount@730d12e. Ruby 1.9.2 won't compile on the current or last major releases of OS X (Mtn. Lion or Lion), so it is not easy for me to test or debug. |
I tried the patch and it compiled okay, though it threw some other errors when in use, so I am afraid to say I moved to another (albeit slower) markdown processor. 1.9.2-p320 compiles on Mountain Lion - I have it installed with RVM. Would love to move back to RDiscount if you are able to fix. |
Hmm. You must have overridden the default llvm-gcc with real gcc. I'll take another look either today or Thursday. |
I think it is bad policy to support anything less than the latest stable Ruby on 1.9.x, so I won't be taking this bug. Please upgrade your Ruby to 1.9.3 or greater when you are able. For more information about Ruby versions I will support, please see the Support Matrix. Closing as Unsupported. |
Reopening to track while I reevaluate 1.9.2 support. |
I'm having the same problem with ruby-1.9.2-p320 |
I don't anticipate having time to fix this myself. If you care enough about Ruby 1.9.2, submit me a patch. Otherwise upgrade to Ruby 1.9.3 or later. Marking for Community Support. |
I have received no patch for this in over a year, so I'm assuming the community does not have a strong enough desire to restore support for the old Ruby 1.9.2 version itself. Closing. |
1.9.2 was not a stable ruby version and has problems to compile all over the place. People should move to 1.9.3 anyway. This removes the issue with rdiscount which you can read up on here: davidfstr/rdiscount#48
Hello,
Running
rake build
fails on my 64-bit computer:Obviously
int
has size 8 (bytes) on a 64-bit machine.Thanks for your consideration.
The text was updated successfully, but these errors were encountered: