-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing extensions for markdown when using Redcarpet #345
Comments
Ah didn't realize there was a PR to address this issue (#300). I still think consolidating down to just a single Tilt::RedcarpetTemplate class would be ideal. |
It's not clear why that pull request (which is the same as your fix) didn't get merged or rejected three years ago. |
This should now be fixed in aea852b. Can you try latest Tilt-master and see it works? |
Thanks @judofyr! That did the trick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue stems from an issue reported in the Sinatra repo: sinatra/sinatra/issues/1440.
The code following sums up the issue:
However notice:
I think the code to try to maintain Redcarpet1 compatibility is creating a problem. Can the Redcarpet1Template be eliminated at this point and we just have a RedcarpetTemplate class?
At a minimum I think the following change needs made, replace:
tilt/lib/tilt.rb
Line 127 in 24aff97
with:
The text was updated successfully, but these errors were encountered: