Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unscoped mode #53

Merged
merged 1 commit into from Aug 15, 2016
Merged

Added unscoped mode #53

merged 1 commit into from Aug 15, 2016

Conversation

neurosnap
Copy link
Contributor

@neurosnap neurosnap commented Aug 13, 2016

So this is my attempt at a no-scope option. It is very similar to #31 but I tried to remove any unnecessary code for the no-scope options.

As you can see I also duplicated all the tests for the no-scope option.

I also made the csjsTemplate parameter an object so it can be a little easier to configure down the road.

Let me know what you think. Thanks.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4999874 on neurosnap:noscope into 5df5123 on rtsao:master.

@avesus
Copy link

avesus commented Aug 13, 2016

Gorgeous!

On Friday, August 12, 2016, Coveralls notifications@github.com wrote:

[image: Coverage Status] https://coveralls.io/builds/7434261

Coverage remained the same at 100.0% when pulling 4999874
4999874
on neurosnap:noscope
into 5df5123
5df5123
on rtsao:master
.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#53 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AD9MI9tTkLmPYuCghaiPzBQftkEn6i3Rks5qfWAtgaJpZM4Jjne9
.

Best Regards,
Ivan Borisenko

@rtsao
Copy link
Owner

rtsao commented Aug 15, 2016

Awesome work! This looks good. 😄

@rtsao rtsao merged commit e4bc564 into rtsao:master Aug 15, 2016
@rtsao rtsao changed the title No scope Added unscoped mode Aug 15, 2016
@rtsao rtsao mentioned this pull request Aug 15, 2016
@avesus
Copy link

avesus commented Aug 27, 2016

Ryan @rtsao when to expect publishing this changes on NPM? I want depend on it in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants