create_instance using cloud availability zone instead of hosts

[dsadaka]

I am creating my first vpc based instance with rubber. I received the error:

Conflict => The CIDR '<hidden>' conflicts with another...

Reading through the code I discovered that availability zone was nil so when vpc looked up the subnet it didn't find it and then tried to create it. Further perusal lead be to the offending code in instances.rb:

def create_instance(instance_alias, instance_roles, create_spot_instance)
role_names = instance_roles.collect{|x| x.name}
env = rubber_cfg.environment.bind(role_names, instance_alias)
cloud_env = env.cloud_providers[env.cloud_provider]

availability_zone = cloud_env.availability_zone

...

instance_item.zone = availability_zone

Shouldn't this be using the hosts availability zone instead of the cloud_providers? After all it's recommended in rubber.yml that this setting be made at the host level. Setup like this, I'm going to have to change the cloud_provider availability_zone each time.

[davebenvenuti]

I think you're right. I will look into this. Thanks!