Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I don't think these assertions can be completed #2

Closed
wants to merge 1 commit into from
Closed

I don't think these assertions can be completed #2

wants to merge 1 commit into from

Conversation

grncdr
Copy link

@grncdr grncdr commented Feb 19, 2011

Two "should" calls inside a nested function were asserting against a var
from the enclosing scope that was not reliably modified on each call to the
nested function. As far as I can tell the nested function can't make any
interesting assertions about said var.

Unless I'm missing something obvious, which is totally possible ;)

Two "should" calls inside a nested function were asserting against a var
from the enclosing scope that was not reliably modified on each call to the
nested function. As far as I can tell the nested function can't make any
interesting assertions about said var.
@davidcarltonsumo
Copy link
Contributor

Yeah, I ran into that too. Though the existing asserts did have a useful didactic purpose for me in the first invocation of add2, because it emphasizes the lazy evaluation of i. I'm not entirely sure what the best solution is to that.

@lamdor
Copy link
Owner

lamdor commented Mar 27, 2011

Yeah, that's a messup on my part I think. Thanks for the patch.

@lamdor lamdor closed this Mar 27, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants