Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in t-SNE momentum gain calculation #6

Closed
andrewdalpino opened this issue Nov 29, 2018 · 0 comments
Closed

Error in t-SNE momentum gain calculation #6

andrewdalpino opened this issue Nov 29, 2018 · 0 comments
Assignees
Labels
bug Something isn't working
Projects

Comments

@andrewdalpino
Copy link
Member

andrewdalpino commented Nov 29, 2018

The computation of the gains for t-SNE Gradient Descent with momentum updates is backwards. Instead of speeding up when the gradient is sloping down, it slows down and vice versa. The effect is slower embedding and clusters that are too close together. Just flip the comparison to less than instead of greater than and boom.

 $gain = $direction[$i][$j] < 0.
     ? $gain + self::INC_GAIN
     : $gain * self::DEC_GAIN;
@andrewdalpino andrewdalpino added the bug Something isn't working label Nov 29, 2018
@andrewdalpino andrewdalpino self-assigned this Nov 29, 2018
@andrewdalpino andrewdalpino added this to Backlog in Roadmap via automation Nov 29, 2018
@andrewdalpino andrewdalpino moved this from Backlog to In progress in Roadmap Nov 29, 2018
@andrewdalpino andrewdalpino moved this from In progress to Review in Roadmap Nov 29, 2018
@andrewdalpino andrewdalpino moved this from Review to Completed in Roadmap Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Roadmap
  
Completed
Development

No branches or pull requests

1 participant