Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdk3: implement Gdk::EventTouch methods #194

Closed
kou opened this issue Oct 14, 2013 · 4 comments
Closed

gdk3: implement Gdk::EventTouch methods #194

kou opened this issue Oct 14, 2013 · 4 comments

Comments

@kou
Copy link
Member

kou commented Oct 14, 2013

Gdk::EventTouch is added since GTK+ 3.4. But we don't implement its accessors yet.

See also: https://github.com/ruby-gnome2/ruby-gnome2/blob/master/gdk3/ext/gdk3/rbgdkevent.c#L978

@cosmo0920
Copy link
Member

I tried to implement Gdk::EventTouch accessors like this:

diff --git a/gdk3/ext/gdk3/rbgdkevent.c b/gdk3/ext/gdk3/rbgdkevent.c
index f643bbf..61540a5 100644
--- a/gdk3/ext/gdk3/rbgdkevent.c
+++ b/gdk3/ext/gdk3/rbgdkevent.c
@@ -720,6 +720,20 @@ ATTR_GOBJ(button, device);
 ATTR_FLOAT(button, x_root);
 ATTR_FLOAT(button, y_root);

+/* GdkEventTouch */
+ATTR_GOBJ(touch, window);
+ATTR_INT(touch, send_event);
+ATTR_UINT(touch, time);
+ATTR_FLOAT(touch, x);
+ATTR_FLOAT(touch, y);
+ATTR_AXES(touch, GdkEventTouch);
+ATTR_FLAGS(touch, state, GDK_TYPE_MODIFIER_TYPE);
+ATTR_GOBJ(touch, sequence); //compile passed, but why?
+ATTR_BOOL(touch, emulating_pointer);
+ATTR_GOBJ(touch, device);
+ATTR_FLOAT(touch, x_root);
+ATTR_FLOAT(touch, y_root);
+
 /* GdkEventScroll */
 ATTR_UINT(scroll, time);
 ATTR_FLOAT(scroll, x);
@@ -975,7 +989,6 @@ Init_gdk_event(VALUE mGdk)
     rb_cGdkEventTouch =
         G_DEF_CLASS_WITH_PARENT(GDK_TYPE_EVENT_TOUCH, "EventTouch",
                                 mGdk, rb_cGdkEvent);
-/* TODO: implement me.
     DEFINE_ACCESSOR(rb_cGdkEventTouch, touch, window);
     DEFINE_ACCESSOR(rb_cGdkEventTouch, touch, send_event);
     DEFINE_ACCESSOR(rb_cGdkEventTouch, touch, time);
@@ -989,7 +1002,6 @@ Init_gdk_event(VALUE mGdk)
     DEFINE_ACCESSOR(rb_cGdkEventTouch, touch, device);
     DEFINE_ACCESSOR(rb_cGdkEventTouch, touch, x_root);
     DEFINE_ACCESSOR(rb_cGdkEventTouch, touch, y_root);
-*/

     /* GdkEventScroll */
     rb_cGdkEventScroll =

But, I didn't fully understand how works ATTR* macro series and how to treat GdkEventSequence *sequence.

@kou
Copy link
Member Author

kou commented Nov 2, 2013

If you write tests into https://github.com/ruby-gnome2/ruby-gnome2/blob/master/gdk3/test/test-gdk-event.rb , you will know about ATTR* macros. Could you try it?

GdkEventSequence is... Umm. It will be useless. So we don't need to bind it.

@cosmo0920
Copy link
Member

If you write tests into https://github.com/ruby-gnome2/ruby-gnome2/blob/master/gdk3/test/test-gdk-event.rb , you will know about ATTR* macros. Could you try it?

Oh, I'll try to write Gdk::EventTouch test!

@kou
Copy link
Member Author

kou commented Nov 3, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants