update script and fix the mistakes I have done #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,7 +2,7 @@ | |||
| =begin | |||
| aboutdialog2.rb - Ruby/GTK sample script. | |||
|
|
|||
| Copyright (c) 2005-2015 Ruby-GNOME2 Project Team | |||
| Copyright (c) 2006-2015 Ruby-GNOME2 Project Team | |||
There was a problem hiding this comment.
Please don't change copyright start year.
There was a problem hiding this comment.
The original started at 2006 . The last commit is a fix to my previous error on this copyright.
There was a problem hiding this comment.
Really?
cedlemo@5f4ebc0#diff-143503283065af58477f247b38700298L5 says
Copyright (c) 2005,2006 Ruby-GNOME2 Project Team
|
Is there something wrong with my pull requests? Should I continue to update the sample scripts or would you want that I make any other modifications? |
kou
added a commit
that referenced
this pull request
Mar 8, 2015
update script and fix the mistakes I have done Patch by cedlemo. Thanks!!!
No. Just I was busy.
Please continue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.