New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rabl not running for DELETE #1894
Comments
I think you're seeing the response from |
Yes, we are using grape-rabl. I tried adding DELETE methods into the grape-rabl test suite and had no issues. I just tried with grape 1.0.3 and stepped through the code. This looks like a potential cause:
The |
I'll test with newer versions of grape and see if issue still occurs. |
Interesting. This probably means we're inserting the middleware in the wrong place. |
I think the problem is that "false" in the return means "no body" https://github.com/ruby-grape/grape/pull/1550/files#diff-e9e8424a5238d48301e313d8fe285697R133 |
I am in the process of upgrading an old Rails app. Just tried increasing Grape from version 0.17.0 to 0.19.2. I hit on issue with the rabl no longer being processed for DELETE.
My API looks like:
And the test that now fails looks a bit like:
The status test passes, but the response body is no longer the JSON generated by my rabl, just simply the string
false
.The text was updated successfully, but these errors were encountered: