Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required ruby version ? #2228

Open
ericproulx opened this issue Jan 3, 2022 · 2 comments
Open

Required ruby version ? #2228

ericproulx opened this issue Jan 3, 2022 · 2 comments

Comments

@ericproulx
Copy link
Contributor

Hello,

Simple question, since Ruby 3.1 is out, is it worth keeping 2.5 as the minimal required_ruby_version ?

I could add a PR adding 3.1 and dropping 2.5.

Thanks

@dblock
Copy link
Member

dblock commented Jan 3, 2022

If there's a good reason, sure. Otherwise unless it's difficult or annoying to preserve compatibility with Ruby 2.5, and if we don't want to take advantage of some feature in 2.5+, I would leave it, we don't try to be too aggressive in upgrading in general.

@dnesteryuk
Copy link
Member

We still use 2.7 and don't plan to upgrade to 3.1, unfortunately, it is slower than 2.7, see more there https://www.reddit.com/r/ruby/comments/royv5z/benchmarking_ruby_25_to_31_and_yjit/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants