Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Rack's HeadersHash instead of {} #2396

Closed
ericproulx opened this issue Dec 31, 2023 · 0 comments · Fixed by #2425
Closed

Use Rack's HeadersHash instead of {} #2396

ericproulx opened this issue Dec 31, 2023 · 0 comments · Fixed by #2425
Labels
chore

Comments

@ericproulx
Copy link
Contributor

According to Rack's upgrade guide, we should use Rack::Headers instead of a single Hash to manage response headers. Furthermore, we always used a{} to manage headers but we should had used Rack::Utils::HeaderHash.

Anyway, I think it would be better than using Grape.lowercase_headers?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace Hash with Rack::Header/Rack::Utils::HeaderHash for Grape Headers dhruvCW/grape
2 participants
@dblock @ericproulx