Grape::API.routes does not work with mounted Grape::API apps. #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You got it. This is clearly a bug and yes, |
|
@dblock How does this look? Seems to do the trick! |
|
Good. I think we can do some minor refactoring on this |
|
Merged with a minor update, please double-check after me: 0f3f14d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This very simple spec shows that the expected number of routes is incorrect. I can enhance these specs further, but I want to get a dialog started before I do too much work. I see that an
Grape::Endpointis added whenmountis invoked. That endpoint is then asked for it'sroutes, but this does not work when the endpoint represents anGrape::API.My question: Should the
Grape::Endpoint#routesmethod understand this issue and answer theGrape::API.routesfrom theoptions[:app]?