params 'missing' due to rack bug

[myitcv]

This commit in rack fixes an issue whereby all requests which use a temp file (all requests larger 128 kb?) fail to be properly parsed.

The issue manifests itself in grape in the following way:

params do
  optional :picture, type: String
end
patch '/' do
  picture_from_params = params[:picture] # nil - but should not be
  picture_from_env = env['rack.request.form_hash']['picture'] # not nil - as expected

  env["rack.request.form_input"].eql? env["rack.input"] # false - THIS IS THE BUG fixed by the commit in rack
  env["rack.request.form_input"].equal? env["rack.input"] # true
end

Indeed this could have been the root cause of a few issues raised in the Google Group.

Not so much an issue from grape's perspective apart from it being the place where this error manifests itself. Definitely something to be aware of when running Ruby 1.9+ (commit comment suggests this doesn't affect Ruby 1.8.x)

So more of an FYI in case anyone else gets bitten by this.

The issue is further complicated by the fact that running rack/test doesn't cross this codepath. Presumably because temp files are not used in tests??

This issue is present in rack == 1.5.2, fixed in master as of the time of this post, but not yet released (expected in 1.5.4 I believe)

[dblock]

I think it would be good to have a test in Grape that breaks right now, then we can lock Rack >= 1.5.4 and merge the test.

[myitcv]

Please see #563 for a first cut at such a test

[myitcv]

Sorry, I'll leave you to close this if you think #563 covers this.

[zuk]

I just spent half a day trying to track this bug down... finally figured it out, came here to report, and found this already here.

Using the github#master version of rack (i.e. rack 1.6.0.alpha) seems to fix the problem by the way.

[olleolleolle]

@zuk rack 1.6.0.beta got released back in August. Your tip helped me a lot.

[dblock]

Grape doesn't lock to a particular Rack version, so now that Rack 1.6.0 has shipped, this works. I committed the test with c72181d.

[dblock]

Note that rack/rack#756 back-ported the fix into Rack 1.5.3.