Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthenticationInitiationHelpers#store_challenge_in_jwt for REST APIs #11

Open
asavageiv opened this issue Apr 22, 2024 · 4 comments
Open

Comments

@asavageiv
Copy link

Would you be interested in a PR that adds store_challenge_in_jwt to AuthenticationInitiationHelpers? This would help out apps that can't use cookies.

@tcannonfodder
Copy link
Contributor

Yes, that’s a great idea! 😄 Thanks for offering to tackle this!

@asavageiv
Copy link
Author

Is storing the challenge in the cookies allowed per the specification?
https://w3c.github.io/webauthn/#sctn-cryptographic-challenges

Could an attacker who can see the cookies being sent replay an authentication request to gain access to the system? Deleting the challenge from the session doesn't prevent that, right?

@tcannonfodder
Copy link
Contributor

tcannonfodder commented Apr 25, 2024

Shit; it’s possible, yeah; based on these docs: https://guides.rubyonrails.org/security.html#replay-attacks-for-cookiestore-sessions

We should have integration or system tests that test this session replay attack scenario; and figure out next steps if it is possible.

my plate is swamped currently, could you write these tests?

@asavageiv
Copy link
Author

Unfortunately I am also swamped at the moment. Do you agree it's a non-issue for HTTPS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants