-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JITSupport use breaks tests under non-CRuby #2
Comments
Please feel free to branch based on |
@k0kubun Will that get wiped out if someone updates |
I have never sync-ed |
In 590e09b @k0kubun added logic to clear JIT logs during the popen2 test using JITSupport.
This breaks the test on implementations that do not have the same JIT flags and RubyVM support as CRuby.
If this logic is still necessary for the test to run on CRuby with JIT enabled, it should be masked to only run on CRuby. If it is no longer needed it should be reverted.
The rest of the
jit_support.rb
file does not seem to be used and was only ported over because it's used by the full test suite in CRuby (ac2e7bd by @hsbt).I have some changes coming to let the open3 tests run on JRuby and include our Windows support files (JRuby only launches subprocesses through Java APIs on Windows, so different logic is required) and can also include this fix.
The text was updated successfully, but these errors were encountered: