Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository not in sync with upstream Ruby master #9

Closed
stomar opened this issue Dec 27, 2019 · 8 comments · Fixed by #10
Closed

Repository not in sync with upstream Ruby master #9

stomar opened this issue Dec 27, 2019 · 8 comments · Fixed by #10
Assignees

Comments

@stomar
Copy link
Contributor

stomar commented Dec 27, 2019

There are both commits in ruby-core that are not synced to this repo and vice versa.

E.g. (not an exhaustive list, only the first two commits I noticed):

  • only in Ruby repo: 048f797 2019-12-22 [ruby/prime] Bump version
  • only here: 55dda6a 2019-08-11 Fix Prime.include? [bug fix not shipped with 2.7.0]

(Of course, my recent commits are not expected to be synced yet.)

Where does development happen? What's the process for syncing?

@stomar
Copy link
Contributor Author

stomar commented Dec 27, 2019

@hsbt, @yugui

@marcandre
Copy link
Member

marcandre commented Dec 27, 2019

Oh... I'm sorry about this. I thought it was done somewhat automatically or regularly 😢

I should have doubled-checked.

I'll fix that.

@marcandre marcandre self-assigned this Dec 27, 2019
@marcandre
Copy link
Member

marcandre commented Dec 27, 2019

Actually @hsbt weren't they was supposed to be sync'ed? That's what I understood from ruby-core:87942. What should can I do to help?

@marcandre
Copy link
Member

I think it would be best to rewrite this repo's history to place the version commit in the right position in the history, and bump the current version to 0.1.2 and release it.
Objections?

@headius
Copy link

headius commented Mar 5, 2020

It doesn't appear any prime gem has been released other than the empty 0.0.1, yes? I'm trying to set up JRuby's 2.6 branch to pull the prime gem, but there's nothing there!

@headius
Copy link

headius commented Mar 6, 2020

Closing the loop: the "prime" gem name is still reserved by someone else, so nothing has been released there. For now I'm restoring the in-repository copy of prime for JRuby.

@marcandre
Copy link
Member

I hope to have some time tomorrow to see what I can do on my end.

@headius
Copy link

headius commented Mar 6, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants