Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RubyGems page Source Code link points to a different repository #1738

Closed
mateusdeap opened this issue Oct 25, 2023 · 9 comments · Fixed by #1803
Closed

RubyGems page Source Code link points to a different repository #1738

mateusdeap opened this issue Oct 25, 2023 · 9 comments · Fixed by #1803
Labels
enhancement New feature or request

Comments

@mateusdeap
Copy link
Contributor

I tried searching for this in the issues but didn't find it.

Was just wondering if you were aware that the URL for the Source Code link of this gem in Ruby Gems actually points to a different prism gem:

image

I tried looking at ruby gems gemspec but found no way to alter this so I'm assuming it's something done by the owners?

The Homepage link is fine, as can be seen, but still, since I usually go for the Source Code link, it threw me off a bit. Also the github badge up top links to the wrong repo.

@hsbt
Copy link
Member

hsbt commented Oct 26, 2023

It may be caused by https://github.com/rubygems/rubygems.org.

@mateusdeap
Copy link
Contributor Author

Interesting. Just to clarify what I meant: maybe it's some configuration that only the people with permissions to publish the gem can alter. But I'm going to check out the code to see if it isn't a bug in the site

@kddnewton
Copy link
Collaborator

This is because we claimed the gem from another person, and that's the old link. Maybe they cache it and don't update it? I probably need to add soemthing to the gemspec to make it update.

@kddnewton
Copy link
Collaborator

@mateusdeap if you figure out the right field, please feel free to open a PR to the gemspec and I'll merge it

@mateusdeap
Copy link
Contributor Author

@kddnewton Will do! I haven't had the time to look into it, but will do so soon enough.

@kddnewton
Copy link
Collaborator

@mateusdeap These 3 lines come from bundle gem foobar

spec.metadata["homepage_uri"] = spec.homepage
spec.metadata["source_code_uri"] = "TODO: Put your gem's public repo URL here."
spec.metadata["changelog_uri"] = "TODO: Put your gem's CHANGELOG.md URL here."

I'm assuming we need to set these options, which we currently aren't in our gemspec. Would you be able to open a PR setting these options?

@kddnewton kddnewton added the enhancement New feature or request label Nov 9, 2023
@mateusdeap
Copy link
Contributor Author

Well, darn, if only I had run that. Funny thing is that I had read the specification reference and did not see those options. Lo and behold, I go back there now and just do a search on the page and find them in the metadata section 🤦

Will open the PR in a bit

@mateusdeap
Copy link
Contributor Author

@kddnewton Done

@kddnewton
Copy link
Collaborator

I imagine it won't update until I push a new version, so we'll wait and see. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants