Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI not detecting failures on JRuby-head #140

Closed
marcandre opened this issue Aug 19, 2020 · 2 comments
Closed

CI not detecting failures on JRuby-head #140

marcandre opened this issue Aug 19, 2020 · 2 comments
Assignees

Comments

@marcandre
Copy link
Member

For some strange reason, failures on jruby-head are not (always?) detected.

An example this run had a failure here, yet was green.

End of run clearly states there was a failure:

Finished in 195.69535 seconds.
-------------------------------------------------------------------------------
53 tests, 215 assertions, 1 failures, 0 errors, 0 pendings, 20 omissions, 0 notifications
96.9697% passed
-------------------------------------------------------------------------------
0.27 tests/s, 1.10 assertions/s
rake aborted!
Command failed with status (1)

Tasks: TOP => test
(See full trace by running task with --trace)
##[error]Process completed with exit code 1.

Similar log on jruby-9.2.11.0 but CI was red (as it should)

The log is humongous but this will be fixed in actions/toolkit#139

@headius, would you mind having a look?

@ahorek
Copy link

ahorek commented Aug 19, 2020

it's in allowed failures 3107211

@marcandre
Copy link
Member Author

Oh, thanks, that explains it. I didn't realize github had such bad support for allowed failures. I just added me 👍to this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants