Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_device.rbs issues #377

Closed
sbeckeriv opened this issue Aug 22, 2020 · 1 comment
Closed

log_device.rbs issues #377

sbeckeriv opened this issue Aug 22, 2020 · 1 comment

Comments

@sbeckeriv
Copy link
Contributor

Dearest maintainer,

I am reading over https://github.com/ruby/rbs/blob/master/stdlib/logger/log_device.rbs#L15 this line here.

def reopen: (?logdev log) -> self

Is this parameter valid syntax? I would expect it to be Logdev.

Second I am unsure what Logdev is. I think based off the comment https://github.com/ruby/logger/blob/master/lib/logger.rb#L405

def reopen: (String | IO | nil) -> self

might make more sense but I am unsure. I am aslo not 100% on the correct syntax. I can make the edits if this is correct.

Thank you for you work and time,

Dictated but not reviewed,
Becker

@sbeckeriv
Copy link
Contributor Author

found type logdev = _WriteCloser | String

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant