Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RDoc for Element #87

Merged
merged 1 commit into from Jun 6, 2022
Merged

Fix RDoc for Element #87

merged 1 commit into from Jun 6, 2022

Conversation

aleksandrilyin
Copy link
Contributor

  • Add missing plus for Element#has_text?.
  • Remove unneeded hash and duplicated the for Element#text.

@aleksandrilyin
Fix RDoc for Element
b16e4ab 
* Add missing plus for `Element#has_text?`.
* Remove unneeded hash and duplicated `the` for `Element#text`.
olleolleolle
olleolleolle approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good finds! Thanks for the PR!

@olleolleolle olleolleolle merged commit afafbac into ruby:master Jun 6, 2022
@olleolleolle
Copy link
Contributor

The build failure on Windows, #88 I reported here, to keep it visible. The cause is probably elsewhere.

@aleksandrilyin aleksandrilyin deleted the fix-element-rdoc branch June 6, 2022 12:32
@aleksandrilyin
Copy link
Contributor Author

The build failure on Windows, #88 I reported here, to keep it visible. The cause is probably elsewhere.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aleksandrilyin @olleolleolle