Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MINGW-UCRT packages #15

Closed
larskanis opened this issue Jun 16, 2021 · 1 comment
Closed

Add support for MINGW-UCRT packages #15

larskanis opened this issue Jun 16, 2021 · 1 comment

Comments

@larskanis
Copy link
Contributor

Currently the packages that are installed are mingw-w64-i686 or mingw-w64-x86_64 depending on the RUBY_PLATFORM: https://github.com/MSP-Greg/setup-ruby-pkgs/blob/331fdbfba8231bbc43d22716c6e773162af807d2/mingw.js#L201

However with the upcoming release of RubyInstaller-3.1 the package prefix has to be mingw-w64-ucrt-x86_64 instead.

Note: The ridk exec or ridk enable commands respect the different MINGW PATH and MINGW package prefix on UCRT already. So if ridk is used everything works already: https://github.com/oneclick/rubyinstaller2/blob/4300b3dbf4c2d9bae1522188ecccf7294b2e7617/lib/ruby_installer/build/msys2_installation.rb#L23-L35

@MSP-Greg
Copy link
Collaborator

Lars,

Code for this has been added to the 'v1' branches of both this repo and ruby/setup-ruby, so it should detect what package to install across Ruby <= 3.0, 3.1, head, mingw, & ucrt.

@MSP-Greg MSP-Greg closed this as completed May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants