Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Bundler version and not having it superseded by the new env var. #443

Closed
RyanRennCN opened this issue Jan 9, 2023 · 2 comments
Closed

Comments

@RyanRennCN
Copy link

RyanRennCN commented Jan 9, 2023

Hello,

With this most recent commit to add BUNDLER_VERSION after installing Bundler, it has impacted the behavior of one of our jobs where two different versions of bundler are used in two different sub-folders.

The first one uses 1.17.3 and this commit then writes out an env var with this version that is then used by the second Setup Ruby action. I tried setting the bundler version as a Ruby input on the second action, but it seems that the env var overwrites it.

For now, I rolled both actions back to use ruby/setup-ruby@v1.133.0, but I would like to understand if there is something different that I should be doing now to set the correct bundler version because of this latest change?

Code:

  - name: Set up Ruby for First Folder
    uses: ruby/setup-ruby@v1
    with:
      ruby-version: '2.7.2'
      bundler-cache: true
      working-directory: ./first_folder
  
  - name: Set up Ruby for Second Folder
    uses: ruby/setup-ruby@v1
    with:
      ruby-version: '2.7.2'
      bundler-cache: true 
      working-directory: ./second_folder

Thank you!

@eregon
Copy link
Member

eregon commented Jan 10, 2023

Please file the issue again using the template, I don't have nearly enough information here to understand the issue. For instance I need to see the logs, what you expect, the more complete workflow file, etc.

@eregon eregon closed this as completed Jan 10, 2023
@RyanRennCN
Copy link
Author

If anyone sees this later, the new issue is this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants