Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate should_not raise_error in MSpec and replaces usages in ruby/spec #754

Open
eregon opened this issue Feb 9, 2020 · 0 comments
Open

Comments

@eregon
Copy link
Member

eregon commented Feb 9, 2020

See https://github.com/ruby/spec/pull/753/files#r376792963

should_not raise_error is the same as testing nothing.
Each example already implicitly test no exception is raised.
There might be a few legit cases, but I would expect the vast majority could be removed and replaced with useful expectations actually testing it works as expected.

Currently there are about 176 should_not raise_error in ruby/spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant