Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert rs to match stringio encoding #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Convert rs to match stringio encoding #80

wants to merge 1 commit into from

Conversation

nobu
Copy link
Member

@nobu nobu commented Jan 16, 2024

Fix #78

@kou
Copy link
Member

kou commented Jan 17, 2024

The current behavior is compatible with IO:

str = "\xFE\xFFColumn1,Column2\n" + "\"value1.1\",value1.2\n"
File.write("/tmp/xxx.txt", str)
File.open("/tmp/xxx.txt", "rb", encoding: "utf-16") do |io|
  io.gets *["\n", 8192]
end

If we want to change the behavior, we may want to change the IO's behavior too.

@kou
Copy link
Member

kou commented Jan 17, 2024

FYI: https://github.com/ruby/ruby/blob/42168802618381b7b6308acc290aabdf61c10116/io.c#L4085-L4087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking Change in v3.0.9
2 participants
@nobu @kou