-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test.filter_backtrace
method doesn't exist
#2
Comments
Thank you to catch this. I'm considering to copy |
@hsbt I verified it with an explicit raise inside an With core-assertions v1.0.1: NoMethodError: undefined method `filter_backtrace' for Test:Module
With core-assertions v1.0.2: Exception raised: <#<RuntimeError: oops>>
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
#assert_nothing_raised
,Test.filter_backtrace
is called in one of the rescue clauses:test-unit-ruby-core/lib/core_assertions.rb
Lines 185 to 191 in c6d86d4
But that method isn't part of
test/unit
. It looks to me like that method is defined here:https://github.com/ruby/ruby/blob/7d26c03267cf1be643963355fc52efde1574b37a/tool/lib/test/unit.rb#L27-L61
I assume that will work when running tests in the ruby repo, but it doesn't seem to work from individual gem repos. I temporarily copied the above into my local
test/lib/helper.rb
and it fixed the issue. Should it simply be moved intocore_assertions
? Or should more oftool/lib/test/unit.rb
be migrated into a different file in this repo?Thanks!
The text was updated successfully, but these errors were encountered: