Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnboundMethod#bind_call is 2.7+ only #19

Closed
headius opened this issue Mar 4, 2021 · 3 comments
Closed

UnboundMethod#bind_call is 2.7+ only #19

headius opened this issue Mar 4, 2021 · 3 comments

Comments

@headius
Copy link
Contributor

headius commented Mar 4, 2021

The uri gem does not specify a minimum Ruby version, but it implicitly requires 2.7+ due to the use of UnboundMethod::bind_call.

JRuby 9.2 available today supports 2.5. JRuby 9.3 due out soon will support 2.6. We will not have a 2.7+ release until JRuby 9.4 later this year.

Is it necessary to use bind_call here? I believe this is the only thing that would prevent the gem from being usable on JRuby 9.2.

@headius
Copy link
Contributor Author

headius commented Mar 4, 2021

There are only two places using bind_call, both inspect methods in the RFC parsers.

@headius
Copy link
Contributor Author

headius commented Mar 4, 2021

@jeremyevans
Copy link
Contributor

I'm fine making bind_call optional and setting required_ruby_version to whatever the earliest version is that passes the specs (after adding specs for inspect). I'll submit a PR for that.

jeremyevans added a commit to jeremyevans/uri that referenced this issue Mar 4, 2021
This allows tests to pass on Ruby 2.4-2.6.

Fixes ruby#19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants