We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
label
The readme mentions:
If you are calling it in a loop, or with different variations, you can include a label on the filename:
flamegraph(label: "rspec") { # your code here }
This is not accurate, as it results in:
ArgumentError: unknown keyword: :label
If the library wants to support both a normal parameter and a keyword arg, it could use:
def flamegraph(_label = nil, label: _label, open: true, ignore_gc: false, interval: 1000, &block)
The text was updated successfully, but these errors were encountered:
Thanks for reporting! I'm not sure which I really intended 🤔
I think I'm alright with keeping it a positional argument, and updating the docs.
Sorry, something went wrong.
Fixed the docs, and added some tests around this. Included in 0.2.0
Successfully merging a pull request may close this issue.
The readme mentions:
This is not accurate, as it results in:
If the library wants to support both a normal parameter and a keyword arg, it could use:
The text was updated successfully, but these errors were encountered: