Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colors not terminated after a quoted symbol :"blah blah" #3

Closed
fowlmouth opened this issue Sep 13, 2011 · 7 comments
Closed

colors not terminated after a quoted symbol :"blah blah" #3

fowlmouth opened this issue Sep 13, 2011 · 7 comments
Assignees
@korny
Labels
Bug Encoders

Comments

@fowlmouth
Copy link

example

It looks like it is detected properly in the scan but the colors aren't terminated after the end quote
@korny
Copy link
Member

korny commented Sep 13, 2011

Looks like a terminal encoder issue. Can you give me your CodeRay::VERSION?

@ghost ghost assigned korny Sep 13, 2011
@fowlmouth
Copy link
Author

0.9.8

@korny
Copy link
Member

korny commented Sep 13, 2011

Thank you :) You're an awesome reporter.

So, nested tokens are giving the terminal encoder trouble. That thing needs a rewrite anyway.

I'll try to fix it in 1.0 (RC), can't guarantee a 0.9 fix.

@fowlmouth
Copy link
Author

Radical

@korny
Copy link
Member

korny commented Sep 13, 2011

Looks like it's already fixed in 1.0. So we can delay the rewrite for now.

@korny
Copy link
Member

korny commented Sep 22, 2011

Okay, 1.0 is out. Can I close this issue, or do you need a 0.9 patch?

@fowlmouth
Copy link
Author

nah you can close it
thanks

@korny korny closed this as completed Sep 23, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korny korny

Labels
Bug Encoders
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fowlmouth @korny