coderay 1.0.0 fails tests on jruby

[graaff]

Trying to run coderay's tests on JRuby (jruby 1.5.6 (ruby 1.8.7 patchlevel 249) (2011-06-08 6586) (OpenJDK 64-Bit Server VM 1.6.0_22) [amd64-java]) gives me the following test failures:

/usr/bin/jruby ./test/unit/suite.rb
Running CodeRay unit tests: comment_filter, count, debug, duo, file_type, filter, json_encoder, lines_of_code, null, plugin, statistic, text, token_kind_filter, tokens, word_list
Loaded suite ./test/unit/suite
Started
..........Block supersedes default value argument; use either.
F.......................F..................
Finished in 0.577 seconds.

  1) Failure:
test_block_supersedes_default_warning(FileTypeTests) [./test/unit/file_type.rb:31]:
<"Block supersedes default value argument; use either.\n"> expected but was
<"">.

  2) Failure:
test_plugin_not_found(PluginScannerTest) [./test/unit/plugin.rb:58]:
<CodeRay::PluginHost::PluginNotFound> exception expected but none was thrown.

53 tests, 158 assertions, 2 failures, 0 errors

[korny]

I tested on 1.6.4. Will investigate.

[korny]

Jup. Strange; what's going on there…

[graaff]

If the conclusion is that jruby 1.5 is broken then that is fine with me, but unfortunately we're still stuck with that version of jruby on Gentoo which means I'll have to wait to add coderay 1.0.0 to Gentoo until that is resolved.

[korny]

I see. Even if it's an incompatibility issue on 1.5.4, I'd like to make it work for you.

• The first Failure is not problematic, since it's just an expected warning missing.
• The second one might also not be a problem if you don't use plugins except for the ones in the distribution.

So I'd say, try to upgrade — even with the failing tests (for now).

[graaff]

We offer our users the option to run tests as part of the installation procedure of a package (for ruby as well as other packages that offer tests), so I can't just update the package without addressing this in a more structured way, either by removing the specific failing tests or depending on jruby 1.6 once that is added to Gentoo. Bit strapped for time now but I'll keep in mind that I can drop those tests if needed.

[korny]

Commit ec60c83 fixes the first issue; the test was broken here, not the library.

The second issue is caused by a JRuby bug that has been fixed in 1.6: http://jira.codehaus.org/browse/JRUBY-4885?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel

[graaff]

Thanks for looking in to this. For Gentoo I've commented out both tests for now, until we can depend on jruby 1.6. I guess this can be closed?

[korny]

Okay.