Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supervisor can view all case contacts #243

Closed
Zrrrpy opened this issue May 11, 2020 · 4 comments
Closed

Supervisor can view all case contacts #243

Zrrrpy opened this issue May 11, 2020 · 4 comments
Labels
📋 Supervisor Work relating to the case supervisor role Priority: High

Comments

@Zrrrpy
Copy link
Collaborator

Zrrrpy commented May 11, 2020

Part of epic #105

What type of user is this for? [volunteer/supervisor/admin]
Supervisor

Where does/should this occur?
In CASA Case Details

Description
Supervisors should be able to view all case_contacts associated with a casa_case including case_contacts from previous volunteer assignments. case_contacts should display in order of date in which they occurred.

Screenshots
CASA case_contacts

Relates to issues
#30, #239

@Zrrrpy Zrrrpy created this issue from a note in CASA Volunteer Portal (To do) May 11, 2020
@Zrrrpy Zrrrpy added 📋 Supervisor Work relating to the case supervisor role Priority: High Status: Available labels May 11, 2020
@Zrrrpy Zrrrpy changed the title Supervisor can view case contacts Supervisor can view all case contacts May 11, 2020
@armahillo
Copy link
Collaborator

Hi! I'm grabbing this. :)

Can you either add me to the repo and assign it to me (I'm in RfG already, diaper project) or mark it as claimed? Thank you!

@armahillo
Copy link
Collaborator

A couple questions I'm trying to sort out:

Supervisors should be able to view all case_contacts associated with a casa_case

  1. How does this differ from normal? I see in the casa_cases#show view that it's already iterating through case_contacts and displaying them.

including case_contacts from previous volunteer assignments.

  1. Is this currently constrained? As far as I can tell, case_assignment and case_contact are independent of one another, though they both associate with casa_case.

Could you specify what the work difference is, here? I'm not completely clear what I'm adding beyond what already exists.

@colinsoleim
Copy link
Collaborator

colinsoleim commented May 11, 2020

@armahillo For 1, you're correct. It looks like the supervisor role already works fine for this particular view/pundit policy.

For 2, I think there's a plan to make changes with case assignments with this issue #230, but at the moment there is nothing that needs to be done.

I'm not sure if this issue can be closed or not, I'll check with the admins. In the meantime, these two issues (#241, #240) relate to the supervisor role have clear behavior that needs to be changed. Thanks for your help, excited to have you on the project :)

@colinsoleim
Copy link
Collaborator

It looks like we're going to keep the current data relationship where casa_case.case_contacts returns both active and inactive case_contacts. I'm going to close this issue because as @armahillo pointed out everything with this issue is currently working.

CASA Volunteer Portal automation moved this from To do to Done May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📋 Supervisor Work relating to the case supervisor role Priority: High
Projects
CASA Volunteer Portal
Done (in prod!)
Development

No branches or pull requests

3 participants