Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group user model validations into an existing UserValidator class #3378

Closed
xihai01 opened this issue Apr 17, 2022 · 4 comments · Fixed by #3390
Closed

Group user model validations into an existing UserValidator class #3378

xihai01 opened this issue Apr 17, 2022 · 4 comments · Fixed by #3390
Assignees
@HeitorMC
Labels
📋 Supervisor Work relating to the case supervisor role 👑 Admin Work relating to the admin role Good First Issue 📱 SMS work relating to SMS notifications #1017 🙌 Volunteer Work relating to the volunteer role
Projects
CASA Volunteer Portal

Comments

@xihai01
Copy link
Collaborator

xihai01 commented Apr 17, 2022

Description
The user model currently has these validations:
Screenshot from 2022-04-17 15-22-33
We would like to group all these validations into the UserValidator class.

Existing gem(s), file(s) needing updating, changing or deleting
app/model/user.rb
app/validators/user_validator.rb

Questions? Join Slack!

We highly recommend that you join us in slack https://rubyforgood.herokuapp.com/ #casa channel to ask questions quickly and hear about office hours (currently Tuesday 6-8pm Pacific), stakeholder news, and upcoming new issues.
@xihai01 xihai01 added 👑 Admin Work relating to the admin role 🙌 Volunteer Work relating to the volunteer role 📋 Supervisor Work relating to the case supervisor role Good First Issue 📱 SMS work relating to SMS notifications #1017 labels Apr 17, 2022
@xihai01 xihai01 self-assigned this Apr 17, 2022
@xihai01 xihai01 added this to To do in CASA Volunteer Portal via automation Apr 17, 2022
@github-actions github-actions bot added the Help Wanted This is a special label that enables github to showcase issues that want help label Apr 17, 2022
@HeitorMC
Copy link
Contributor

Hello there! 🎉 I would like to be assign for this issue 😄

@xihai01 xihai01 assigned HeitorMC and unassigned xihai01 Apr 19, 2022
@xihai01
Copy link
Collaborator Author

xihai01 commented Apr 19, 2022

I've assigned you @HeitorMC

@compwron compwron moved this from To do to In progress in CASA Volunteer Portal Apr 19, 2022
@github-actions github-actions bot removed the Help Wanted This is a special label that enables github to showcase issues that want help label Apr 19, 2022
@HeitorMC
Copy link
Contributor

Hey @xihai01 just to confirm, you want to remove e-mail, display_name and at_least_one_communication_preference_selected validations from the model and pass to the UserValidator class, right?

@xihai01
Copy link
Collaborator Author

xihai01 commented Apr 22, 2022

Hey @xihai01 just to confirm, you want to remove e-mail, display_name and at_least_one_communication_preference_selected validations from the model and pass to the UserValidator class, right?

Yes, that is correct

@HeitorMC HeitorMC mentioned this issue Apr 25, 2022
Merged
CASA Volunteer Portal automation moved this from In progress to Merged to QA Apr 29, 2022
@github-actions github-actions bot moved this from Merged to QA to Done (in prod!) in CASA Volunteer Portal May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HeitorMC HeitorMC

Labels
📋 Supervisor Work relating to the case supervisor role 👑 Admin Work relating to the admin role Good First Issue 📱 SMS work relating to SMS notifications #1017 🙌 Volunteer Work relating to the volunteer role
Projects
CASA Volunteer Portal
Done (in prod!)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

3378 - Group user model validations into an existing UserValidator class HeitorMC/casa
2 participants
@HeitorMC @xihai01