Bug: Admins/Supervisors Learning Hours Tab - Clicking on Volunteer name not routing to Volunteer's Learning Hours Page

[sarvaiyanidhi]

Impacted User Types

• supervisors?
• admins?

Current Behavior

As per recent changes implemented in issue #5474 When the Admin or Supervisor clicks on the volunteer's name in the "Learning Hours" page, they are routed to "Learning Hour" show page but by passing volunteer id to find learning hour.

As a result system is throwing below error as it is not able to find Learning Hour for given Volunteer id

Expected Behavior

When the Admin or Supervisor clicks on the volunteer's name in "Learning Hours", they should be routed to that Volunteer's Learning Hours page so they see what types of learnings the volunteer has done.

How to Replicate

ex:

• Log in as a supervisor
• Click on "Learning Hours" in the left sidebar menu.
• Click on a volunteer name

How to access the QA site

Login Details:
Link to QA site

Login Emails:

• volunteer1@example.com view site as a volunteer
• supervisor1@example.com view site as a supervisor
• casa_admin1@example.com view site as an admin
• all_casa_admin1@example.com view site as an all casa admin
  • go to /all_casa_admins/sign_in

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack #casa channel to ask questions quickly. And discord for office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

[sarvaiyanidhi]

While evaluating implementation for current code to add test for issue #5513 I found that in currently implemented code there is issue in implementation as on click of volunteer name in supervisor learning page it is passing learning_hour.user_id and redirecting it to learning_hours controller show page which is trying to find learning hour using user id.

As per requirement mentioned in issue #5474 , we need to show all learning hours of Volunteer and not specific learning hour as implemented.

I also wanted to check instead of redirecting to Volunteer's learning hour page on click of Volunteer name, should we show for Supervisor and Casa Admin learning hours for Volunteer on its learning hour page itself as we do for Other duties so that view is similar across all pages.

[bcastillo32]

While evaluating implementation for current code to add test for issue #5513 I found that in currently implemented code there is issue in implementation as on click of volunteer name in supervisor learning page it is passing learning_hour.user_id and redirecting it to learning_hours controller show page which is trying to find learning hour using user id.

As per requirement mentioned in issue #5474 , we need to show all learning hours of Volunteer and not specific learning hour as implemented.

I also wanted to check instead of redirecting to Volunteer's learning hour page on click of Volunteer name, should we show for Supervisor and Casa Admin learning hours for Volunteer on its learning hour page itself as we do for Other duties so that view is similar across all pages.

Hi @sarvaiyanidhi thank you for bringing this to our attention. Yes, you are correct - we want the supervisors/admins to be taken to what the volunteers see on their learning hours page. Those details are important to the supervisors/admins. For Other duties - we can do the same where we take the supervisor/admin to what the volunteer sees. But if you like we can handle it on a separate ticket. Let me know what you prefer.

[sarvaiyanidhi]

Thank you for the clarification. Will look into this after completing other tickets. Thanks

[jp524]

Hi there, I am working on #5550 which is related. Just to let you know that my PR should also resolve this issue.

[sarvaiyanidhi]

Thank you Jade for the heads up.