Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Phone Number Input #5573

Closed
bcastillo32 opened this issue Mar 16, 2024 · 14 comments · Fixed by #5796
Closed

Update Phone Number Input #5573

bcastillo32 opened this issue Mar 16, 2024 · 14 comments · Fixed by #5796
Assignees
Labels
Difficulty: Intermediate Spans multiple domains or requires more advanced coding knowledge Stakeholder-Feature A feature requested by the stakeholders

Comments

@bcastillo32
Copy link
Collaborator

Impacted User Types

  • supervisors
  • admins

Current Behavior

When supervisors create a new volunteer profile, they must input the volunteer's phone number in a specific way. Update this input box to accept phone numbers in the following formats:

International: +1XXXXXXXXXX

Basic: XXXXXXXXXX, 1XXXXXXXXXX

Hyphenated: XXX-XXX-XXXX, 1-XXX-XXX-XXXX

Spaced: XXX XXX XXXX, 1 XXX XXX XXXX

Parentheses: (XXX)XXXXXXX, (XXX) XXX-XXXX, 1(XXX)XXX-XXXX

Dots: XXX.XXX.XXXX, 1.XXX.XXX.XXXX

Note: If entering all of these formats is not possible, include the necessary text to prompt the user to enter in the correct format (1 example is good) and please include placeholder text in the input box with the correct format.

How to access the QA site

Login Details:
Link to QA site

Login Emails:

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack #casa channel to ask questions quickly. And discord for office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

@bcastillo32 bcastillo32 added Type: Bug Help Wanted This is a special label that enables github to showcase issues that want help labels Mar 16, 2024
@bcastillo32 bcastillo32 changed the title Update Phone Number Update Phone Number Input Mar 17, 2024
@bcastillo32 bcastillo32 added Stakeholder-Feature A feature requested by the stakeholders and removed Type: Bug labels Mar 17, 2024
@zsalikmtc
Copy link

I would love to take a crack at this! Once approved, is it recommended to make a branch to work on the issue? Thank you!

@bcastillo32 bcastillo32 removed the Help Wanted This is a special label that enables github to showcase issues that want help label Mar 30, 2024
@bcastillo32
Copy link
Collaborator Author

I would love to take a crack at this! Once approved, is it recommended to make a branch to work on the issue? Thank you!

Hi @zsalikmtc apologies for the delayed response I was out and then had to catch up on some stuff for work. Plz do create a new branch and let me know if you run into any issues. Thank you for working on this - it was a big ask from our users :)

@zsalikmtc
Copy link

I would love to take a crack at this! Once approved, is it recommended to make a branch to work on the issue? Thank you!

Hi @zsalikmtc apologies for the delayed response I was out and then had to catch up on some stuff for work. Plz do create a new branch and let me know if you run into any issues. Thank you for working on this - it was a big ask from our users :)

Hi @bcastillo32 Thank you so much! I created a branch and have been hacking away at this, and should have some good results soon.

Would you be able to give me access to push the branch to the repo? It gave me a permission denied, not sure if I just need to be granted access. Thanks so much!

@bcastillo32
Copy link
Collaborator Author

I would love to take a crack at this! Once approved, is it recommended to make a branch to work on the issue? Thank you!

Hi @zsalikmtc apologies for the delayed response I was out and then had to catch up on some stuff for work. Plz do create a new branch and let me know if you run into any issues. Thank you for working on this - it was a big ask from our users :)

Hi @bcastillo32 Thank you so much! I created a branch and have been hacking away at this, and should have some good results soon.

Would you be able to give me access to push the branch to the repo? It gave me a permission denied, not sure if I just need to be granted access. Thanks so much!

Hi @zsalikmtc sounds great! I will find out about access to push to repo and get back to you asap.

@bcastillo32
Copy link
Collaborator Author

@zsalikmtc we also have some info here that might answer your question. Let me know if this helps.

@bcastillo32
Copy link
Collaborator Author

@zsalikmtc I confirmed the process is to fork the casa repository, work on that copy (since its your copy you can freely push changes) and when you want to you open a pull request to get your local changes into the main repository. Info can be found in the contributing guide I linked above.

@zsalikmtc
Copy link

Sounds good @bcastillo32! I will follow those steps. Take care!

Copy link

This issue has been inactive for 248 hours (10.33 days) and will be unassigned after 112 more hours (4.67 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

@zsalikmtc
Copy link

zsalikmtc commented Apr 22, 2024 via email

Copy link

github-actions bot commented May 3, 2024

This issue has been inactive for 263 hours (10.96 days) and will be unassigned after 97 more hours (4.04 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

@compwron
Copy link
Collaborator

compwron commented May 6, 2024

I am continuing to work on this, and will create a PR as soon as I am ready by mid-week.

On Apr 21, 2024 at 20:15 -0400, github-actions[bot] @.>, wrote: This issue has been inactive for 248 hours (10.33 days) and will be unassigned after 112 more hours (4.67 days). If you have questions, please If you are still working on this, comment here to tell the bot to give you more time — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.>

very cool :)

@bcastillo32
Copy link
Collaborator Author

hi @zsalikmtc I hope you are well. how are things coming along? Are you blocked at all?

Copy link

This issue has been inactive for 240 hours (10.00 days) and will be unassigned after 120 more hours (5.00 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

Copy link

This issue has been inactive for 360 hours (15.00 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

@elasticspoon elasticspoon added Help Wanted This is a special label that enables github to showcase issues that want help Difficulty: Intermediate Spans multiple domains or requires more advanced coding knowledge labels May 27, 2024
@freestylebit freestylebit self-assigned this May 31, 2024
@github-actions github-actions bot removed the Help Wanted This is a special label that enables github to showcase issues that want help label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: Intermediate Spans multiple domains or requires more advanced coding knowledge Stakeholder-Feature A feature requested by the stakeholders
Projects
Status: Merged to QA
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants