Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case Contact Form Update: Change Section "1. Select the relevant cases" picker to Dropdown style like in Section 2. Select All Contact Types #5776

Open
3 tasks
Tracked by #5755
bcastillo32 opened this issue May 27, 2024 · 2 comments · May be fixed by #5867
Assignees
Labels
Difficulty: Intermediate Spans multiple domains or requires more advanced coding knowledge ⏯️ Frontend Make things look fresh & work better on the frontend.

Comments

@bcastillo32
Copy link
Collaborator

bcastillo32 commented May 27, 2024

What type(s) of user does this feature affect?

  • volunteers
  • supervisors
  • admins

Description:

In the volunteer view of the case contact form (/case_contacts/:id/form/details), there are typically only two or three cases under the “select a case” question.

Image

However, in the supervisor view, they see all cases handled by their volunteers. In the supervisor view, this question can be overwhelming to view.

Image

Please apply the same picker style from Section 2 to section 1 in the Case Contact form.
image

image

Criteria for completion:

  • update the UI to a multi-select instead of a checkbox selection
  • make sure that users are able to select multiple cases since they could be filling out a case contact for siblings
  • in the supervisor view, make sure that the dropdown includes volunteer name after case to assist in selecting the correct case

How to access the QA site

Login Details:
Link to QA site

Login Emails:

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack #casa channel to ask questions quickly. And discord for office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

@elasticspoon elasticspoon added ⏯️ Frontend Make things look fresh & work better on the frontend. Difficulty: Intermediate Spans multiple domains or requires more advanced coding knowledge labels May 27, 2024
@bcastillo32 bcastillo32 added the Help Wanted This is a special label that enables github to showcase issues that want help label Jun 22, 2024
@bcastillo32 bcastillo32 self-assigned this Jun 25, 2024
@github-actions github-actions bot removed the Help Wanted This is a special label that enables github to showcase issues that want help label Jun 25, 2024
@bcastillo32 bcastillo32 removed their assignment Jun 25, 2024
@kenny-luong
Copy link

Happy to work on this

@kenny-luong
Copy link

kenny-luong commented Jun 26, 2024

So I noticed an issue with one of the specs.

spec/system/case_contacts/new_spec.rb

line 128: re-renders the form with errors, but preserving all previously entered selections

My understanding of this spec is that it's not only testing error enforcing, but also making sure that it retains the previous selections.

It seems that "Contact Type" is not actually a required field despite being labeled as one.

image

You can actually move forward in the form without having selected a contact type.

This is happening because we call complete_details_page twice. The first time will select all of the contact types as expected but the second call actually removes all of the selections.

Thoughts on what we want to do here? This is preventing me from updating the spec to handle the case selection.

My initial suggestion is to create another method targeted at filling in the missing field (in this case, it would be the medium type) or changing the missing field to be the case ids instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: Intermediate Spans multiple domains or requires more advanced coding knowledge ⏯️ Frontend Make things look fresh & work better on the frontend.
Projects
Status: In Progress
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants