2262/purchase error messages #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or failed purchase creation error display
… error messages in response.
PhilipDeFraties
commented
Apr 5, 2021
| @@ -71,7 +71,7 @@ | |||
| it "renders GET#new with error" do | |||
| post purchases_path(default_params.merge(purchase: { storage_location_id: nil, amount_spent_in_cents: nil })) | |||
| expect(response).to be_successful # Will render :new | |||
| expect(response).to have_error(/error/i) | |||
| expect(response.body).to include('Failed to create purchase due to: ["Storage location must exist", "Vendor must exist", "Amount spent in cents is not a number"]') | |||
There was a problem hiding this comment.
Not sure if this is ok, basically copied from the POST#create failure test in partners_request_spec
There was a problem hiding this comment.
@PhilipDeFraties this is okay :)!
edwinthinks
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
@PhilipDeFraties excellent work! Thank you for your help here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2262
Description
Changes purchases#create error flash to provide full error messages.
To stay in line with precedent set for error handling I referred to partners#create
Type of change
How Has This Been Tested?
Adds context block for failed purchase creation in purchase_system_spec.rb which contains added test, also moves a similiar test for failed purchase creation concerning item dropdown to within said block.
Had to edit purchase request POST#create failure test, the previous assertion was different:
I copied the test that was in the partners_request_spec POST#create failure test. I'm unsure if this is ok, I'm unfamiliar with the assertion that was previously there which stopped working once I changed the error message.
Screenshots