Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color of trackable too close to default gray color #50

Closed
squiggie opened this issue Apr 1, 2016 · 10 comments
Closed

Color of trackable too close to default gray color #50

squiggie opened this issue Apr 1, 2016 · 10 comments
Assignees
Milestone

Comments

@squiggie
Copy link

squiggie commented Apr 1, 2016

The gray color of a trackable item is too close to the default color and could be mistaken for the items not being clickable/working. I actually thought something was wrong with the Back Pain trackable and it wasn't clickable when I first noticed it. See screen shot.

http://prntscr.com/amthgn

Consider either darkening the gray or not using a color so close to the default color.

@lmerriam
Copy link
Collaborator

lmerriam commented Apr 1, 2016

Well that's a bug -- grey isn't one of our colors! I think maybe this trackable hasn't been assigned a color yet for some reason.

@lmerriam
Copy link
Collaborator

lmerriam commented Apr 5, 2016

I got this too today:
screenshot 2016-04-05 18 07 09
screenshot 2016-04-05 18 18 39

Routing to the chart and back and refreshing the page did not fix.
The funny thing is that I added two new trackables within seconds, but only one the first one got this grey color. I wonder if this is the point at which colors start over and repeat, and there's some index mismatch?

@lmerriam
Copy link
Collaborator

lmerriam commented Apr 5, 2016

Just added several trackables and got a lot of repeating of the same blue color:
screenshot 2016-04-05 18 15 56

@lmerriam
Copy link
Collaborator

lmerriam commented Apr 5, 2016

(This is not very high priority unless it is a simple fix)

@lmerriam
Copy link
Collaborator

Another user is seeing the issue: https://talk.flaredown.com/t/report-a-bug/135/103

@lmerriam
Copy link
Collaborator

Adding this to launch because multiple users are reporting it

@lmerriam lmerriam added this to the Launch milestone Apr 19, 2016
@lmerriam lmerriam added the bug label Apr 19, 2016
@algodave algodave self-assigned this Apr 19, 2016
algodave added a commit that referenced this issue May 3, 2016
- ensure the new color has never been used
- when colors end up, repeat in order
@algodave
Copy link
Contributor

algodave commented May 3, 2016

@lmerriam I've fixed the root causes of the issue and now it works fine for new users who haven't done onboarding yet. In order to fix it for existing users, I need to run ad-hoc scripts to ensure that each trackable in their checkins has a different color than the others. To do so, I'll need to put the app in maintenance mode during this night (your time)

@lmerriam
Copy link
Collaborator

lmerriam commented May 3, 2016

Nice! I'm fine with putting the app in maintenance.

@algodave
Copy link
Contributor

algodave commented May 4, 2016

@lmerriam Fixing colors on existing data in order to avoid duplications was a challenge, there might still be edge cases where duplicates are still there - e.g.: when all colors have been used on a user's trackables over time, repetition could happen within the same trackables' subgroup (e.g. conditions)
A further optimization could be o avoid such repetition. I would suggest to fix individual cases that might happen as users report them, and open a new issue labeled as "enhancement" to tackle later.

@algodave algodave closed this as completed May 4, 2016
@lmerriam
Copy link
Collaborator

lmerriam commented May 4, 2016

Absolutely, that is the right call. I do not want to spend a lot of time fixing a few remaining cases if it's been fixed for users going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants