Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date issues #9

Closed
lmerriam opened this issue Feb 17, 2016 · 1 comment
Closed

Date issues #9

lmerriam opened this issue Feb 17, 2016 · 1 comment
Assignees
Milestone

Comments

@lmerriam
Copy link
Collaborator

Two issues I can reproduce:

  • Clicking on a date on the graph takes me to the prior day in the check-in
  • Clicking the arrow to move to the previous day in the check-in moves me back two days, clicking the arrow to move to the next day in the check-in does not do anything
@lmerriam lmerriam added the bug label Feb 17, 2016
@algodave algodave self-assigned this Feb 17, 2016
@lmerriam lmerriam modified the milestone: Launch Feb 24, 2016
@algodave
Copy link
Contributor

What could happen (although I didn't reproduce) is that checkin was created at a different date than the one passed by the client, because it was passing date with zulu-formatted time&zone info (which we actually don't need). In case of difference in date between the client and the server (due to time-zone) it could cause the above bugs.

@lmerriam Could you please make some tests and let me know? Also note: you might find some of your existing checkins in a different day than you were seeing before. As we don't matter about actual data at this stage, just let me know if the above flows are fixed and work as expected - thanks!

Also make sure you're clicking once when you move forward or backwards: consider that when no checkin exists in the previous/next day, it takes a bit more because it needs to be created (you can see API calls in Network tab if you like). Of course we can optimize that and disable those buttons once the user has clicked, until the transition to the next/previous day completes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants