function get.biome() arguments

[ValentineHerr]

Opening this issue to make sure someone double checks it is okay if the function get.biome() defined here, apparently needs 5 arguments but that up to 9 are given in line 40 of get.biome.R

[jaydorsey]

I don't think I ever actually dug into the function itself, but that definitely looks problematic.

Maybe @potterzot can provide some insight?

I do know at one point we were writing files out (necessitating the additional file names and paths and such) because another process was using that temp file(s). We abandoned that approach for using Ruby RServe, so it's possible that the additional arguments are truly no longer necessary.

I would defer to the R code in the GHGVCR repository being authoritative, so maybe the get_biome.R function in this repo should be updated to reflect the newer 5 argument method? Hopefully Nick will jump in and confirm or deny.