Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEv2]: Evaluate template for missing components #2965

Closed
meg-gutshall opened this issue Jun 8, 2022 · 13 comments
Closed

[FEv2]: Evaluate template for missing components #2965

meg-gutshall opened this issue Jun 8, 2022 · 13 comments
Labels
Design Front-end v2 Everything to do with the website redesign Needs Discussion
Milestone

Comments

@meg-gutshall
Copy link
Member

meg-gutshall commented Jun 8, 2022

Summary

This issue is part of the front-end redesign of the Human Essentials app.

We've chosen to implement the admin dashboard template Mosaic for the redesign. First, we must go through all the current pages in our app and ensure all the components we need are included in Mosaic. If not, that's okay! We have a wonderful designer who has volunteered to create any components that are missing, however, we need to identify what exactly these are.

Steps

The goal of this meta issue is to break up the work amongst several people to make this front-end redesign go as smoothly as possible. You'll need to access the app on the staging environment for this issue.

Access the Staging Environment

Navigate to: https://staging.humanessentials.app/

Login as a Sample User

To login to the web application, use these default credentials:

Super Users

username: superadmin@example.com
password: password!

Bank Users

Organization Admin
  Email: org_admin1@example.com
  Password: password!

User
  Email: user_1@example.com
  Password: password!

Partner Users

Verified Partner
  Email: verified@example.com
  Password: password!

Invited Partner
  Email: invited@pawneehomeless.com
  Password: password!
  
Unverified Partner
  Email: unverified@pawneepregnancy.com
  Password: password!
  
Recertification Required Partner
  Email: recertification_required@example.com
  Password: password!

Pick a View

This meta issue consists of multiple checkboxes, listing different pages. Choose an item from the View/Partial Listings section below and navigate to a page that contains that view/partial. Compare the elements on the page in our current app against the Mosaic Demo admin dashboard template.

If Mosaic's admin dashboard template can reproduce all components in the view/partial...

Great! Mark the checkbox next to the view/partial so everyone knows it's been assessed, then move on to the next one.

If the view/partial contains components not included in Mosaic's admin dashboard template...

Now it's time to open a new issue, a process we've made incredibly easy for this project. Just navigate to the New Issue Form: Missing Components for Redesign to get started. Change the title of the issue to reflect the current view/partial you're assessing. From there, you'll give the following information:

  • Is it part of Human Essentials or Partner Base?
  • Its name (the file path listed next to the checkbox in this issue)
  • The URL of the page where you see it rendered in staging
  • A description of the components missing from the Mosaic template
  • Screenshots of the page where you see it rendered in staging
  • Any other relevant information

View/Partial Listings

Follow the documentation in the links above and check off the boxes below. If you have questions on something, leave a comment on this issue and tag @meg-gutshall.

Account Request Mailer

  • account_request_mailer/approval_request.html.erb
  • account_request_mailer/confirmation.html.erb
  • account_request_mailer/rejection.html.erb

Account Requests

  • account_requests/index.html.erb
  • account_requests/new.html.erb
  • account_requests/confirm.html.erb
  • account_requests/confirmation.html.erb
  • account_requests/invalid_token.html.erb
  • account_requests/received.html.erb

Active Storage

Blobs

  • active_storage/blobs/_blob.html.erb

Adjustments

  • adjustments/index.html.erb
  • adjustments/new.html.erb
  • adjustments/show.html.erb

Admin

  • admin/dashboard.html.erb

Account Requests

  • admin/account_requests/_open_account_request.html.erb
  • admin/account_requests/_rejection_modal.html.erb
  • admin/account_requests/for_rejection.html.erb
  • admin/account_requests/index.html.erb

Barcode Items

  • admin/barcode_items/_barcode_item_row.html.erb
  • admin/barcode_items/_barcode_modal.html.erb
  • admin/barcode_items/_form.html.erb
  • admin/barcode_items/edit.html.erb
  • admin/barcode_items/index.html.erb
  • admin/barcode_items/new.html.erb
  • admin/barcode_items/show.html.erb

Base Items

  • admin/base_items/_base_item_row.html.erb
  • admin/base_items/_dropdown.html.erb
  • admin/base_items/_form.html.erb
  • admin/base_items/edit.html.erb
  • admin/base_items/index.html.erb
  • admin/base_items/new.html.erb
  • admin/base_items/show.html.erb

Organizations

  • admin/organizations/_list.html.erb
  • admin/organizations/_organization_row.html.erb
  • admin/organizations/edit.html.erb
  • admin/organizations/index.html.erb
  • admin/organizations/new.html.erb
  • admin/organizations/show.html.erb

Partners

  • admin/partners/edit.html.erb
  • admin/partners/index.html.erb
  • admin/partners/show.html.erb

Questions

  • admin/questions/_question_form.html.erb
  • admin/questions/edit.html.erb
  • admin/questions/index.html.erb
  • admin/questions/new.html.erb

Users

  • admin/users/_user_form_fields.html.erb
  • admin/users/edit.html.erb
  • admin/users/index.html.erb
  • admin/users/new.html.erb

Audits

Barcode Items

  • barcode_items/_barcode_item_lookup.html.erb
  • barcode_items/_barcode_item_row.html.erb
  • barcode_items/_barcode_modal.html.erb
  • barcode_items/forms.html.erb
  • barcode_items/edit.html.erb
  • barcode_items/index.html.erb
  • barcode_items/new.html.erb
  • barcode_items/show.html.erb

Base Items

  • base_items/_dropdown.html.erb

Consolidated Logins

  • consolidated_logins/new.html.erb

Dashboard

  • dashboard/_distribution.html.erb
  • dashboard/_donation.html.erb
  • dashboard/_getting_started_progress_stepper.html.erb
  • dashboard/getting_started_prompt.html.erb
  • dashboard/_itemized_partial.html.erb
  • dashboard/_manufacturer.html.erb
  • dashboard/_product_drive.html.erb
  • dashboard/_purchase.html.erb
  • dashboard/index.html.erb

Distribution Mailer

  • disribution_mailer/_distribution_changes.html.erb
  • disribution_mailer/partner_mailer.html.erb
  • disribution_mailer/reminder_email.html.erb

Distributions

  • distributions/_daily_item_row.html.erb
  • distributions/_distribution_item_row.html.erb
  • distributions/_distribution_item_total.html.erb
  • distributions/_distribution_row.html.erb
  • distributions/_distribution_total.html.erb
  • distributions/_form.html.erb
  • distributions/_pickup_day_row.html.erb
  • distributions/edit.html.erb
  • distributions/index.html.erb
  • distributions/new.html.erb
  • distributions/pickup_day.html.erb
  • distributions/print.html.erb
  • distributions/schedule.html.erb
  • distributions/show.html.erb

Donation Sites

  • donation_sites/_donation_site_row.html.erb
  • donation_sites/_form.html.erb
  • donation_sites/edit.html.erb
  • donation_sites/index.html.erb
  • donation_sites/new.html.erb
  • donation_sites/show.html.erb

Donations

  • donations/_donation_form.html.erb
  • donations/_donation_item_row.html.erb
  • donations/_donation_row.html.erb
  • donations/_scale_fields.html.erb
  • donations/add_item.html.erb
  • donations/edit.html.erb
  • donations/index.html.erb
  • donations/new.html.erb
  • donations/removw_item.html.erb
  • donations/show.html.erb

Errors

  • errors/403.html.erb
  • errors/404.html.erb
  • errors/500.html.erb
  • errors/insufficient.html.erb
  • errors/internal_server_error.html.erb
  • errors/not_found.html.erb

Forecasting

Distributions

  • forecasting/distributions/index.html.erb

Donations

  • forecasting/donations/index.html.erb

Purchases

  • forecasting/purchases/index.html.erb

Help

  • help/_bank_questions.html.erb
  • help/show.html.erb

Item Categories

  • item_categories/_form.html.erb
  • item_categories/edit.html.erb
  • item_categories/new.html.erb
  • item_categories/show.html.erb

Items

  • items/_forms.html.erb
  • items/_header.html.erb
  • items/_item_categories.html.erb
  • items/_item_list.html.erb
  • items/_item_row_quanitity_and_storages.html.erb
  • items/_item_row.html.erb
  • items/_items_quantity_and_location.html.erb
  • items/_kits.html.erb
  • items/_storage_column.html.erb
  • items/edit.html.erb
  • items/index.html.erb
  • items/new.html.erb
  • items/show.html.erb

Kaminari

  • kaminari/_first_page.html.erb
  • kaminari/_gap.html.erb
  • kaminari/_last_page.html.erb
  • kaminari/_next_page.html.erb
  • kaminari/_page.html.erb
  • kaminari/_paginator.html.erb
  • kaminari/_prev_page.html.erb

Kits

  • kits/_form.html.erb
  • kits/_table.html.erb
  • kits/allocations.html.erb
  • kits/index.html.erb
  • kits/new.html.erb

Layouts

  • layouts/_devise_shared.html.erb
  • layouts/_lte_admin_navbar.html.erb
  • layouts/_lte_admin_sidebar.html.erb
  • layouts/_lte_navbar.html.erb
  • layouts/_lte_sidebar.html.erb
  • layouts/application.html.erb
  • layouts/devise.html.erb
  • layouts/mailer.html.erb
  • layouts/partner.html.erb

Action Text

Contents
  • layouts/action_text/contents/_content.html.erb

Navigation

  • layouts/navigation/_footer.html.erb
  • layouts/navigation/_header.html.erb
  • layouts/navigation/_layout.html.erb
  • layouts/navigation/_sidebar.html.erb

Partners

  • layouts/partners/application.html.erb
Navigation
  • layouts/partners/naviagtion/_navbar.html.erb
  • layouts/partners/naviagtion/_sidebar.html.erb

Line Items

  • line_items/_line_item_fields.html.erb

Manufacturers

  • manufacturers/_form.html.erb
  • manufacturers/_manufacturer_row.html.erb
  • manufacturers/_new_modal.html.erb
  • manufacturers/edit.html.erb
  • manufacturers/index.html.erb
  • manufacturers/new.html.erb
  • manufacturers/show.html.erb

Organization Mailer

  • organization_mailer/partner_approval_request.html.erb

Organizations

  • organizations/_details.html.erb
  • organizations/_header.html.erb
  • organizations/edit.html.erb
  • organizations/show.html.erb

Partner Groups

  • partner_groups/_form.html.erb
  • partner_groups/edit.html.erb
  • partner_groups/new.html.erb

Partner Mailer

  • partner_mailer/application_approved.html.erb
  • partner_mailer/recertification_request.html.erb

Partners

  • partners/_documents.html.erb
  • partners/_form.html.erb
  • partners/_partner_groups_table.html.erb
  • partners/_partner_row.html.erb
  • partners/_partners_table.html.erb
  • partners/_show_header.html.erb
  • partners/_statuses.html.erb
  • partners/_uninvited_header.html.erb
  • partners/edit.html.erb
  • partners/index.html.erb
  • partners/new.html.erb
  • partners/show.html.erb

Authorized Family Members

  • partners/authorized_family_members/_form.html.erb
  • partners/authorized_family_members/edit.html.erb
  • partners/authorized_family_members/new.html.erb
  • partners/authorized_family_members/show.html.erb

Children

  • partners/children/_form.html.erb
  • partners/children/_list.html.erb
  • partners/children/edit.html.erb
  • partners/children/index.html.erb
  • partners/children/new.html.erb
  • partners/children/show.html.erb

Dashboards

  • partners/dashboards/_family_details.html.erb
  • partners/dashboards/_requests_in_progress.html.erb
  • partners/dashboards/show.html.erb

Distributions

  • partners/distributions/_distribution_section.html.erb
  • partners/distributions/index.html.erb

Families

  • partners/families/_form.html.erb
  • partners/families/_list.html.erb
  • partners/families/edit.html.erb
  • partners/families/index.html.erb
  • partners/families/new.html.erb
  • partners/families/show.html.erb

Family Requests

  • partners/family_requests/_list.html.erb
  • partners/family_requests/new.html.erb

Helps

  • partners/helps/_partner_questions.html.erb
  • partners/helps/show.html.erb

Individual Requests

  • partners/individual_requests/_item_request.html.erb
  • partners/individual_requests/new.html.erb

Profiles

  • partners/profiles/edit.html.erb
  • partners/profiles/show.html.erb
Edit
  • partners/profiles/edit/_agency_distribution_information.html.erb
  • partners/profiles/edit/_agency_information.html.erb
  • partners/profiles/edit/_agency_stability.html.erb
  • partners/profiles/edit/_attached_documents.html.erb
  • partners/profiles/edit/_diaper_pick_up_person.html.erb
  • partners/profiles/edit/_executive_director.html.erb
  • partners/profiles/edit/_media_information.html.erb
  • partners/profiles/edit/_organizational_capacity.html.erb
  • partners/profiles/edit/_population_served.html.erb
  • partners/profiles/edit/_sources_of_funding.html.erb
Show
  • partners/profiles/show/_agency_distribution_information.html.erb
  • partners/profiles/show/_agency_information.html.erb
  • partners/profiles/show/_agency_stability.html.erb
  • partners/profiles/show/_attached_documents.html.erb
  • partners/profiles/show/_diaper_pick_up_person.html.erb
  • partners/profiles/show/_executive_director.html.erb
  • partners/profiles/show/_media_information.html.erb
  • partners/profiles/show/_organizational_capacity.html.erb
  • partners/profiles/show/_population_served.html.erb
  • partners/profiles/show/_sources_of_funding.html.erb

Requests

  • partners/requests/_error.html.erb
  • partners/requests/_history.html.erb
  • partners/requests/_item_request.html.erb
  • partners/requests/_request_options_card.html.erb
  • partners/requests/_success.html.erb
  • partners/requests/index.html.erb
  • partners/requests/new.html.erb
  • partners/requests/show.html.erb

Users

  • partners/users/index.html.erb
  • partners/users/new.html.erb

Product Drive Participants

  • product_drive_participants/_form.html.erb
  • product_drive_participants/_new_modal.html.erb
  • product_drive_participants/_product_drive_participant_row.html.erb
  • product_drive_participants/edit.html.erb
  • product_drive_participants/index.html.erb
  • product_drive_participants/new.html.erb
  • product_drive_participants/show.html.erb

Product Drives

  • product_drives/_form.html.erb
  • product_drives/_new_modal.html.erb
  • product_drives/edit.html.erb
  • product_drives/index.html.erb
  • product_drives/new.html.erb
  • product_drives/show.html.erb

Profiles

  • profiles/_show.html.erb
  • profiles/edit.html.erb

Purchases

  • purchases/_purchase_form.html.erb
  • purchases/_purchase_item_row.html.erb
  • purchases/_purchase_row.html.erb
  • purchases/edit.html.erb
  • purchases/index.html.erb
  • purchases/new.html.erb
  • purchases/show.html.erb

Reminder Deadline Mailer

  • reminder_deadline_mailer/notify_deadline.html.erb

Reports

Annual Reports

  • reports/annual_reports/index.html.erb
  • reports/annual_reports/show.html.erb

Request Mailer

  • request_mailer/request_cancel_partner_notification.html.erb

Requests

  • requests/_calculate_product_totals.html.erb
  • requests/_request_row.html.erb
  • requests/_status.html.erb
  • requests/index.html.erb
  • requests/show.html.erb

Cancellation

  • requests/cancellation/new.html.erb

Requests Confirmation Mailer

  • requests_confirmation_mailer/confirmation_email.html.erb

Shared

  • shared/_csv_import_modal.html.erb
  • shared/_date_range_picker.html.erb
  • shared/_deadline_day_fields.html.erb
  • shared/_flash_tailwind.html.erb
  • shared/_flash.html.erb
  • shared/_highcharts.html.erb
  • shared/_logo_line.html.erb
  • shared/_table_row_form.html.erb

Static

  • static/index.html.erb
  • static/privacypolicy.html.erb

Storage Locations

  • storage_locations/_form.html.erb
  • storage_locations/_inventory_item_row.html.erb
  • storage_locations/_line_item_row.html.erb
  • storage_locations/_source.html.erb
  • storage_locations/_storage_location_row.html.erb
  • storage_locations/edit.html.erb
  • storage_locations/index.html.erb
  • storage_locations/new.html.erb
  • storage_locations/show.html.erb

Transfers

  • transfers/_transfer_row.html.erb
  • transfers/index.html.erb
  • transfers/new.html.erb
  • transfers/show.html.erb

Users

  • users/_add_user_modal.html.erb
  • users/_organization_user.html.erb
  • users/_organization_users_table.html.erb
  • users/index.html.erb
  • users/new.html.erb

Confirmations

  • users/confirmations/new.html.erb

Invitations

  • users/invitations/edit.html.erb
  • users/invitations/new.html.erb

Mailer

  • users/mailer/confirmation_instructions.html.erb
  • users/mailer/email_changed.html.erb
  • users/mailer/invitation_instructions.html.erb
  • users/mailer/password_change.html.erb
  • users/mailer/reset_password_instructions.html.erb
  • users/mailer/unlock_instructions.html.erb

Passwords

  • users/passwords/edit.html.erb
  • users/passwords/new.html.erb

Registrations

  • users/registrations/edit.html.erb
  • users/registrations/new.html.erb

Sessions

  • users/sessions/new.html.erb

Shared

  • users/shared/_account_management_menu.html.erb
  • users/shared/_links.html.erb

Unlocks

  • users/unlocks/new.html.erb

Vendors

  • vendors/_form.html.erb
  • vendors/_new_modal.html.erb
  • vendors/_vendor_row.html.erb
  • vendors/edit.html.erb
  • vendors/index.html.erb
  • vendors/new.html.erb
  • vendors/show.html.erb

Resources

@meg-gutshall meg-gutshall added Design NOT READY Front-end v2 Everything to do with the website redesign labels Jun 8, 2022
@meg-gutshall meg-gutshall added this to the Front-end v2 milestone Jun 8, 2022
@meg-gutshall meg-gutshall self-assigned this Jun 8, 2022
@github-actions
Copy link
Contributor

This issue has been inactive for 262 hours (10.92 days) and will be automatically unassigned after 98 more hours (4.08 days).

@edwinthinks
Copy link
Collaborator

@meg-gutshall do you think this could be a good thing to work on in RfG coming up?

@github-actions
Copy link
Contributor

This issue has been inactive for 250 hours (10.42 days) and will be automatically unassigned after 110 more hours (4.58 days).

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

This issue has been inactive for 370 hours (15.42 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.

@meg-gutshall meg-gutshall self-assigned this Aug 8, 2022
@scooter-dangle
Copy link
Collaborator

Hey @meg-gutshall, does this one still require discussion before someone can work on it (still has the NOT READY label and [WIP] in the title)?

@meg-gutshall
Copy link
Member Author

There's one TODO that I left in there but I think I'm going to take it out and open up this issue for work today to avoid scope creep on the issue.

@meg-gutshall meg-gutshall changed the title [WIP] Meta issue: Evaluate template for missing components Meta issue: Evaluate template for missing components Aug 16, 2022
@meg-gutshall meg-gutshall added Help Wanted Groomed + open to all! Good First Issue Suitable for users that are newer or less experienced and removed NOT READY labels Aug 16, 2022
@meg-gutshall
Copy link
Member Author

Open sesame!

@github-actions
Copy link
Contributor

This issue has been inactive for 240 hours (10.00 days) and will be automatically unassigned after 120 more hours (5.00 days).

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

This issue has been inactive for 360 hours (15.00 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.

@meg-gutshall meg-gutshall changed the title Meta issue: Evaluate template for missing components [FEv2]: Evaluate template for missing components Sep 24, 2022
@scooter-dangle scooter-dangle removed the Help Wanted Groomed + open to all! label Sep 25, 2022
@scooter-dangle
Copy link
Collaborator

Note: Removing Help Wanted ahead of Hacktoberfest. Might re-label afterward.

@scooter-dangle scooter-dangle removed the Good First Issue Suitable for users that are newer or less experienced label Sep 25, 2022
@seanmarcia
Copy link
Member

Hey @meg-gutshall and everyone else watching this issue. I'm thinking about this and moving it forward in terms of Hacktoberfest since we tend to get a lot folks coming around wanting to contribute and help.

I'm wonder if we want to keep it as a meta issue as I imagine that by the time we'd finish it that October will be over and we'll lose all the folks who could do the implementation :)

  • If we do want to keep it as a Meta issue do we have a template for folks to follow or are they just supposed to be using their best judgement? I could see this going two ways for people: ie - Current page X has a table and it looks like the new system has table templates so this page is good to go? or Looks like current page X has a table with buttons in it but the new template has tables but I don't see any with buttons in it so it looks like it is missing stuff.
    Does anyone know there have been any spikes or has anything been done to start/test doing any of the implementation work with any pages being converted?
    My thought is to create some issues and just say "convert page X", use page Z on this branch as a template.

@meg-gutshall
Copy link
Member Author

Hey @seanmarcia ! I'm going to work on this over the weekend to break down the meta issue into smaller ones.

Yes, it will be comparing the current site with the new template site to see if it can be reproduced using the template alone. I have an issue template for those pages that cannot be reproduced using the template alone that the contributor will open.

After I clean this up and break out the issues, it will hopefully be an easier-to-follow workflow.

@edwinthinks
Copy link
Collaborator

Closing this issue as per the ADR regarding not going with TailwindCSS - #3217. I know not everyone was on that call so please ask any questions in the slack channel about why this choice was made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Front-end v2 Everything to do with the website redesign Needs Discussion
Projects
None yet
Development

No branches or pull requests

4 participants