Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Inactive storage location shows up when choosing Default Location in the Partners page (or in _any_ storage location dropdown) #3353

Closed
3 tasks
scooter-dangle opened this issue Jan 29, 2023 · 2 comments · Fixed by #3382
Assignees
Labels
Help Wanted Groomed + open to all!

Comments

@scooter-dangle
Copy link
Collaborator

scooter-dangle commented Jan 29, 2023

Summary

Inactive storage locations appear in the dropdown for "Default Location" when adding/editing a partner (AND other locations: see list in details section)

Why change?

Simplicity/avoiding user error for the banks

Details

If you have an inactive location, it still shows up in the Default Location dropdown in the partner agency edit page. It shouldn't!

Other possible culprit dropdowns

  • Purchases
  • Donations
  • Distributions
  • Inventory adjustments

We think that's it. There might be one other.

Things to know:

Original request: Human Essentials Support Jan 8 2023 0848

Criteria for completion

  • inactive locations no longer show up in drop down for partner default location
  • tests supporting this
  • find the other storage location drop downs that include inactive locations and apply the same fix
@scooter-dangle scooter-dangle added the Help Wanted Groomed + open to all! label Jan 29, 2023
@kev-kev
Copy link
Collaborator

kev-kev commented Feb 6, 2023

Hi, can I be assigned this issue please?

@dorner dorner assigned dorner and kev-kev and unassigned dorner Feb 6, 2023
@dorner
Copy link
Collaborator

dorner commented Feb 6, 2023

It's yours!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Groomed + open to all!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants