Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] If you leave out the donation site on a donation, it has disappeared when the error is thrown and you come back in #4157

Closed
cielf opened this issue Mar 3, 2024 · 4 comments · Fixed by #4263
Closed

[Bug] If you leave out the donation site on a donation, it has disappeared when the error is thrown and you come back in #4157

cielf opened this issue Mar 3, 2024 · 4 comments · Fixed by #4263
Assignees
@luca652
Labels
Good First Issue Suitable for users that are newer or less experienced stale

Comments

@cielf
Copy link
Collaborator

cielf commented Mar 3, 2024

Summary

If you don't provide a donation site on a new donation, then attempt to save, the donation site field should be available. It isn't.

Details

Currently if you select "Donation Site", but don't select a donation site, and save, you get something like this.
Image

It should be more like this:

Image

Criteria for completion

  • donation site field appears appropriately when there is an error on a new donation
  • tests to demonstrate this functionality
@cielf cielf added the Good First Issue Suitable for users that are newer or less experienced label Mar 3, 2024
@luca652
Copy link
Contributor

luca652 commented Mar 5, 2024

@cielf I would like to work on this one please!

@dorner
Copy link
Collaborator

dorner commented Mar 5, 2024

Go for it!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Apr 5, 2024
@luca652
Copy link
Contributor

luca652 commented Apr 9, 2024

Hi, sorry for the delay. I am getting some advice on the slack channel but I am almost done with this!

@luca652 luca652 mentioned this issue Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luca652 luca652

Labels
Good First Issue Suitable for users that are newer or less experienced stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4157 donation site visible after error luca652/human-essentials
3 participants
@dorner @cielf @luca652