add faker for child first names in seed file #4375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
requested changes
May 22, 2024
There was a problem hiding this comment.
If the goal is unique names, we probably should be using Faker.unique: https://github.com/faker-ruby/faker?tab=readme-ov-file#ensuring-unique-values
|
Updated the code to add .unique to the first names. |
dorner
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4295
Description
Names for children in the seed file were using both the first and last name of the associated Guardian. Changed this to generate a random first name using faker, but left last name the same so it can be easily seen who is in the same family. Since change was only in seed file, it did not seem that any changes to tests or additional tests were needed.
Type of change
How Has This Been Tested?
Seeded database before change and viewed relevant data in postico, saw that children names for a given family all matched the guardian name. Reset database, made change and reseeded, then viewed in postico again to confirm names were no longer the same. As far as I could tell, there were no tests in the spec folder for testing the seed file.